Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Update method signature to match parent class #366

Merged
merged 2 commits into from
Oct 20, 2024
Merged

API Update method signature to match parent class #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21b5487
ENH Use config instead of runtime code to remove menu item
GuySartorelli Oct 14, 2024
c13c127
API Update method signature to match parent class
GuySartorelli Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions _config.php
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions src/Controllers/CMSPageHistoryViewerController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ class CMSPageHistoryViewerController extends CMSMain

private static $required_permission_codes = 'CMS_ACCESS_CMSMain';

private static $ignore_menuitem = true;

public function getEditForm($id = null, $fields = null)
{
$record = $this->getRecord($id ?: $this->currentPageID());
Expand Down
4 changes: 3 additions & 1 deletion src/Controllers/HistoryViewerController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ class HistoryViewerController extends LeftAndMain

private static $required_permission_codes = 'CMS_ACCESS_CMSMain';

private static $ignore_menuitem = true;

private static array $url_handlers = [
'GET api/read' => 'apiRead',
'POST api/revert' => 'apiRevert',
Expand All @@ -65,7 +67,7 @@ class HistoryViewerController extends LeftAndMain
/**
* Returns configuration required by the client app
*/
public function getClientConfig()
public function getClientConfig(): array
{
$clientConfig = parent::getClientConfig();
foreach ($this->formNames as $formName) {
Expand Down
Loading