Don't run queries when trying to retrieve versions for unsaved records #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime-rainville
force-pushed
the
pulls/1/dont-get-versions-on-null-db
branch
3 times, most recently
from
28cbfaa
to
69be629
Compare
1 task
maxime-rainville
force-pushed
the
pulls/1/dont-get-versions-on-null-db
branch
from
69be629
to
7991603
Compare
| @@ -893,6 +893,15 @@ public function testAllVersions() | |||
| $this->assertEquals($extraFields, ['2005', '2007', '2009'], 'Additional version fields returned'); | |||
| } | |||
|
|
|||
| public function testAllVersionsOnUnsavedRecord() | |||
| { | |||
| $newPage = new VersionedTest\Subclass(); | |||
There was a problem hiding this comment.
Those tests passed with the old logic.
maxime-rainville
changed the title
1 task
emteknetnz
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if you call
allVersionson a singleton DataObject, it will try to run a query ... which is nonsensical. This is causing grievances to our graphql--no-databasebuild steps.Parent issue
--no-databaseschema build fails with various module configuration silverstripe-graphql#445