Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hdf5plugin.Bitshuffle to avoid raising ValueError when lz4=False #309

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

psteinb
Copy link
Contributor

@psteinb psteinb commented Jun 26, 2024

Just ran into this problem and would like to avoid other users to see a ValueError if they do:

f = h5py.File('test.h5', 'w')
f.create_dataset(
    'bitshuffle_with_lz4',
    data=numpy.arange(100),
    **hdf5plugin.Bitshuffle(nelems=0, lz4=False, cname='zstd'))
f.close()

Copy link
Member

@t20100 t20100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@t20100 t20100 merged commit d9789b3 into silx-kit:main Jun 27, 2024
5 of 7 checks passed
@t20100 t20100 added this to the 5.0.0 milestone Jul 3, 2024
@t20100 t20100 changed the title avoid throwing ValueError if user sets lz4=False Fixed hdf5plugin.Bitshuffle to avoid raising ValueError when lz4=False Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants