Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split lint from build and update GitHub actions #139

Merged
merged 1 commit into from
Jun 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,20 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout 🏷️
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Base Setup 🕹️ 🐍
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

- name: Install dependencies ⚙️
- name: Install requirements ⚙️
run: python -m pip install -U jupyterlab>=4.0 check-manifest

- name: Install dependencies ⚙️
run: jlpm install

- name: Build the extension 🏗️
run: |
set -eux
jlpm
jlpm run lint
python -m pip install .

jupyter labextension list 2>&1 | grep -ie "jupyterlab-h5web.*OK"
Expand All @@ -41,14 +42,14 @@ jobs:
rm -rf jupyterlab_h5web

- name: Upload debug logs on failure 📬
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
if: failure()
with:
name: Build log
path: |
/tmp/*.log

- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
with:
name: jupyterlab_h5web-dist
path: dist
29 changes: 29 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Lint

on:
push:
branches:
- main
pull_request:
branches:
- main
workflow_call:

jobs:
lint:
runs-on: ubuntu-latest
steps:
- name: Checkout 🏷️
uses: actions/checkout@v4

- name: Base Setup 🕹️ 🐍
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

- name: Install requirements ⚙️
run: python -m pip install -U jupyterlab>=4.0

- name: Install dependencies ⚙️
run: jlpm install

- name: Lint 🏗️
run: jlpm run lint
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Download the built extension
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
name: jupyterlab_h5web-dist
path: dist
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
},
"devDependencies": {
"@jupyterlab/builder": "^4.0.0",
"@types/node": "^18.15.11",
"@types/node": "^20.14.9",
"@types/react": "^18.0.0",
"@types/react-dom": "^18.0.0",
"@typescript-eslint/eslint-plugin": "^5.55.0",
Expand Down
13 changes: 2 additions & 11 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1603,7 +1603,7 @@ __metadata:
languageName: node
linkType: hard

"@types/node@npm:*":
"@types/node@npm:*, @types/node@npm:^20.14.9":
version: 20.14.9
resolution: "@types/node@npm:20.14.9"
dependencies:
Expand All @@ -1612,15 +1612,6 @@ __metadata:
languageName: node
linkType: hard

"@types/node@npm:^18.15.11":
version: 18.19.39
resolution: "@types/node@npm:18.19.39"
dependencies:
undici-types: ~5.26.4
checksum: d1de755983127b405458c427ae2cf77c89d120a617ca70999086a75fb0b6c6dbc1bdddfe1a8a7374c9ae55ed0589a2bd023ffb3b09ee25440c013afc6502dfe6
languageName: node
linkType: hard

"@types/normalize-package-data@npm:^2.4.0":
version: 2.4.4
resolution: "@types/normalize-package-data@npm:2.4.4"
Expand Down Expand Up @@ -5201,7 +5192,7 @@ __metadata:
"@jupyterlab/ui-components": ^4.0.0
"@lumino/widgets": ^2.0.0
"@react-hookz/web": ^24.0.4
"@types/node": ^18.15.11
"@types/node": ^20.14.9
"@types/react": ^18.0.0
"@types/react-dom": ^18.0.0
"@typescript-eslint/eslint-plugin": ^5.55.0
Expand Down