Improve unitutils #1963
Merged
Improve unitutils #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kif
reviewed
Oct 4, 2023
vallsv
force-pushed
the
fix-convert-to-d2
branch
from
7fafb4a to
83bfa61
Compare
vallsv
force-pushed
the
fix-convert-to-d2
branch
from
83bfa61 to
a49a57c
Compare
|
The PR can be reviewed. It includes your fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1962 this PR provides more flexible conversion for
r,q,d*2usingunit.space.Plus add const
RecD2_A(symmetric toRecD2_NM)A test was added to check the new implementation versus the previous one.