Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new arg parser for 1d #2016

Merged
merged 6 commits into from
Dec 21, 2023
Merged

new arg parser for 1d #2016

merged 6 commits into from
Dec 21, 2023

Conversation

EdgarGF93
Copy link
Collaborator

@EdgarGF93 EdgarGF93 commented Dec 13, 2023

  • New parser arguments: pixel split, algorithm, implementation...
  • Correct typos and prints
  • Update documentation
  • Fix integrate2d benchmark

New attributes for "pyFAI-benchmark" tool (only 1d integration works fine so far)

New arguments for argument parser:

  • Pixel splitting argument (-ps, --pixelsplit): no, bbox, pseudo, full, all (default=bbox)
  • Algorithm argument: histogram (-algo, --algorithm), CSR, CSC, LUT, all (default=histogram, CSR)
  • Implementation argument (-i, --impl): python, cython, opencl, all (default=cython, opencl)
  • Function argument (-f, --function): legacy, ng, all (default=all)
  • all argument (--all) (boolean): if True, benchmarks every available method (default=False)
  • Not processor argument (--no-proc): if used, skips the benchmark using the central processor (useful if you want to benchmark only GPU devices using --gpu)
  • Some changes in the figure legends to be consistent with the documentation of AzimuthalIntegrator

image

@EdgarGF93 EdgarGF93 added the work in progress Don't review label Dec 13, 2023
@EdgarGF93 EdgarGF93 requested a review from kif December 13, 2023 12:33
@EdgarGF93
Copy link
Collaborator Author

EdgarGF93 commented Dec 20, 2023

  • Tested 2d integration.
  • Clearer plot with legends outside of the axes.
  • Annotated vertical dashed lines to indicate the specific detector to benchmark
    Figure_1
    (after typing pyFAI-benchmark -f ng -2d -algo csr --gpu)

@kif kif merged commit d68c622 into silx-kit:main Dec 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work in progress Don't review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants