Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the orientation selection in the calibration GUI (v2) #2020

Merged
merged 6 commits into from
Dec 21, 2023

Conversation

kif
Copy link
Member

@kif kif commented Dec 18, 2023

close #2005

@kif kif requested a review from vallsv December 18, 2023 10:17
@kif kif added gui Affects only the graphical user interface ready to merge Please review labels Dec 18, 2023
@vallsv
Copy link
Collaborator

vallsv commented Dec 20, 2023

You should create a dedicated class for the orientation.
You can feel like it is overkill, but that's the way not to be over bloated with implementation details after years.

  • set/get will deal with your enum values, you don't have to think about
  • you can put your component inside detector-selection-drop.ui directly

Except that, if it works, it works.

@kif kif merged commit 2aa034a into silx-kit:main Dec 21, 2023
8 checks passed
@kif
Copy link
Member Author

kif commented Dec 21, 2023

The modification you suggest has been put into #2027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui Affects only the graphical user interface ready to merge Please review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Calib2] Offer the option to chose the orientation of the detector
2 participants