Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of warning emited by MSVC #2329

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Conversation

kif
Copy link
Member

@kif kif commented Nov 12, 2024

No description provided.

@kif
Copy link
Member Author

kif commented Nov 12, 2024

The other remaining warnings are due to Cython itself.

@kif
Copy link
Member Author

kif commented Nov 12, 2024

Close #2323

@kif kif requested review from EdgarGF93 and mjdiff November 12, 2024 10:52
@kif kif added the ready to merge Please review label Nov 12, 2024
@kif
Copy link
Member Author

kif commented Nov 12, 2024

All warnings were linked to implicit conversion of int <-> double

@kif kif merged commit 17936e4 into silx-kit:main Nov 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants