Using old pointer after reallocating new buffer #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simo5
requested changes
Sep 3, 2024
src/objects.c
Outdated
| void *ptr = OPENSSL_realloc(key->attrs, sizeof(CK_ATTRIBUTE) * (key->numattrs + add_attrs)); | ||
| if (!ptr) { | ||
| key->attrs = OPENSSL_realloc(key->attrs, sizeof(CK_ATTRIBUTE) * (key->numattrs + add_attrs)); | ||
| if (!key->attrs) { |
There was a problem hiding this comment.
On failure realloc will leave the original pointer untouched, so the correct way is to use ptr, and only if it is not null then key->attrs = ptr;
That was the original intention of this code and the bug is the missing overwriting of key->attrs after the null check.
There was a problem hiding this comment.
Hi @simo5
Updated the code, thanks for the pointer.
Below issue is reported while running TLS1.3:- p11prov_DeriveKey:Host out of memory Issue occurs because we are trying to use deallocated memory pointer after reallocating new memory due to which key->attrs get corrupted and finally cause issue in importing correct peer key. Signed-off-by: Kshitiz Varshney <[email protected]>
kshitizvars
force-pushed
the
EC_MOCK_PEER
branch
from
21d7789
to
d9e9f47
Compare
|
Oh I just realized this PR is on my personal repo, I will integrate the original patch and your fix on top of another PR I am working on in the same area, but it may take me a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below issue is reported while running TLS1.3:-
p11prov_DeriveKey:Host out of memoryIssue occurs because we are trying to use deallocated memory pointer after reallocating new memory due to which key->attrs get corrupted and finally cause issue in importing correct peer key.