Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLADE-728 upgrade configuration to support gradle 7 #58

Closed
wants to merge 44 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
a5cd5da
BLADE-707 update sample minimal workspace name
simonjhy Feb 13, 2023
6ca6f03
BLADE-707 SF
simonjhy Feb 13, 2023
1bcc2e5
Merge pull request #261 from simonjhy/BLADE-707
simonjhy Feb 13, 2023
64e0f4c
BLADE-709 fix client extension sample workspace renamed issue
simonjhy Feb 20, 2023
7cb7f30
Merge pull request #264 from simonjhy/BLADE-709
simonjhy Feb 20, 2023
61b98da
BLADE-708 fix gradle tooling performance issue
simonjhy Feb 20, 2023
16fa5a3
BLADE-708 SF
simonjhy Feb 20, 2023
f50267d
Merge pull request #262 from simonjhy/BLADE-708
simonjhy Feb 20, 2023
b416b01
BLADE-710 install liferay js failed when path contain blank spaces
simonjhy Feb 28, 2023
a5dd891
Merge pull request #265 from simonjhy/BLADE-710
simonjhy Mar 1, 2023
e06e9e1
BLADE-712 check the file last modify date before download
simonjhy Mar 1, 2023
73db600
BLADE-712 SF
simonjhy Mar 1, 2023
96475c7
BLADE-712 improve download performance
simonjhy Mar 2, 2023
c9c6baa
BLADE-712 add smoke test for client extenstion sample
simonjhy Mar 3, 2023
fed725e
BLADE-712 return local file path when uri start with file
simonjhy Mar 4, 2023
40f19e2
Merge pull request #268 from simonjhy/BLADE-712
simonjhy Mar 5, 2023
6d76272
BLADE-712 improve blade samples command logic
simonjhy Mar 5, 2023
9be3202
Merge pull request #269 from simonjhy/BLADE-712-1
simonjhy Mar 5, 2023
b904983
BLADE-711 Update blade server start error message
Mar 3, 2023
42e8931
BLADE-711 update github actions
simonjhy Mar 7, 2023
07e4c53
Merge pull request #271 from simonjhy/BLADE-711
simonjhy Mar 7, 2023
a5827cd
BLADE-713 Use latest project template
simonjhy Apr 14, 2023
9ab67f1
BLADE-713 SF
simonjhy Apr 14, 2023
134a103
Merge pull request #272 from simonjhy/BLADE-713
simonjhy Apr 18, 2023
8b17f95
BLADE-714 use latest project template
simonjhy Apr 25, 2023
70674f7
Merge pull request #274 from simonjhy/BLADE-714
simonjhy Apr 25, 2023
3b6308f
BLADE-716 set correct target platform for project template
simonjhy Apr 27, 2023
a8b20a9
BLADE-716 add test form simulator
simonjhy Apr 27, 2023
7f75b89
Merge pull request #275 from simonjhy/BLADE-716
simonjhy Apr 28, 2023
0625cc4
BLADE-717 Update samples url
lawrence-lee May 8, 2023
129b79c
BLADE-717 Update Test
lawrence-lee May 8, 2023
1d8fbc9
BLADE-717 fix client extension test error
simonjhy May 9, 2023
b075c95
BLADE-717 SF
simonjhy May 9, 2023
ecfda7e
Merge pull request #277 from simonjhy/BLADE-717
simonjhy May 9, 2023
5bc974e
BLADE-719 use latest project template 5.0.246
simonjhy May 19, 2023
93e713a
BLADE-719 update workspace plugin version for initBundle test
simonjhy May 21, 2023
6339efc
Merge pull request #278 from simonjhy/BLADE-719
simonjhy May 21, 2023
9c84835
BLADE-724 liferay-blade-cli: always use the latest release of the pro…
drewbrokke Jul 18, 2023
76835e0
BLADE-725 create release document
gamerson Jul 25, 2023
52ae5b9
Merge pull request #279 from drewbrokke/BLADE-724-TASK-v0-update-rele…
drewbrokke Jul 25, 2023
a928cdf
BLADE-725 add changelog command
gamerson Aug 2, 2023
152ef55
Merge pull request #280 from liferay/BLADE-725
gamerson Aug 2, 2023
dca591d
BLADE-728 upgrade blade configuraton for gradle 7
simonjhy Aug 14, 2023
34a299b
BLADE-728 improve build.gradle for gradle 7
simonjhy Aug 15, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 30 additions & 24 deletions .github/workflows/verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ env:
jobs:
CheckSourceFormatting:
name: Check source formatting
runs-on: ubuntu-18.04
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v1
Expand All @@ -34,17 +34,19 @@ jobs:
./gradlew --no-daemon checkSourceFormatting
LinuxJDK8:
name: Linux JDK8
runs-on: ubuntu-18.04
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- name: Checkout
uses: actions/checkout@v1
- name: Set up JDK8
uses: actions/setup-java@v1
- name: Check out repository
uses: actions/checkout@v3
- name: Setup Java 8
uses: actions/setup-java@v3
with:
java-version: 1.8
java-version: 8
distribution: 'zulu'
cache: gradle
- name: Cache
uses: actions/cache@v1
uses: actions/cache@v3
with:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
Expand All @@ -71,17 +73,19 @@ jobs:
token: "7793a209-c075-4644-9bdb-9205dbe5c4e7"
LinuxJDK11:
name: Linux JDK11
runs-on: ubuntu-18.04
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- name: Checkout
uses: actions/checkout@v1
- name: Set up JDK11
uses: actions/setup-java@v1
- name: Check out repository
uses: actions/checkout@v3
- name: Setup Java 11
uses: actions/setup-java@v3
with:
java-version: 11
distribution: 'zulu'
cache: gradle
- name: Cache
uses: actions/cache@v1
uses: actions/cache@v3
with:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
Expand All @@ -106,19 +110,21 @@ jobs:
label: "Linux JDK11 test reports"
report: "**/TEST-*.xml"
token: "7793a209-c075-4644-9bdb-9205dbe5c4e7"
MacOSJDK8:
name: MacOS JDK8
MacOSJDK11:
name: MacOS JDK11
runs-on: macos-latest
timeout-minutes: 60
steps:
- name: Checkout
uses: actions/checkout@v1
- name: Set up JDK8
uses: actions/setup-java@v1
- name: Check out repository
uses: actions/checkout@v3
- name: Setup Java 11
uses: actions/setup-java@v3
with:
java-version: 1.8
java-version: 11
distribution: 'zulu'
cache: gradle
- name: Cache
uses: actions/cache@v1
uses: actions/cache@v3
with:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
Expand All @@ -134,13 +140,13 @@ jobs:
uses: actions/upload-artifact@v1
if: failure()
with:
name: MacOSJDK8-tests.zip
name: MacOSJDK11-tests.zip
path: tests.zip
- name: Run reporter
uses: check-run-reporter/[email protected]
if: ${{ always() }}
with:
label: "MacOS JDK8 test reports"
label: "MacOS JDK11 test reports"
report: "**/TEST-*.xml"
token: "7793a209-c075-4644-9bdb-9205dbe5c4e7"
#WindowsJDK8:
Expand Down
39 changes: 39 additions & 0 deletions RELEASE.markdown
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# How to Release

## Create a stable release

1. Create a BLADE jira ticket for the new release

1. Create a new branch based on ticket

1. Run `gradlew prepareRelease`

1. Commit the changes

1. Generate changelog`./gradlew -b changelogs-sdk.gradle buildChangelogs`

1. Commit the changelog

1. Create PR on `liferay/liferay-blade-cli` repo from this branch

1. If the PR passes all the tests, merge the PR to master.

1. Generate a new tag based on the new version `git tag 4.1.2`

1. Push the tags to upstream `git push --tags upstream`

By merging this PR to master, and since all of the versions of the components are set to stable versions, this will cause the GitHub workflow to release the binaries to nexus which will cause the existing blade CLIs to report a new stable release/version is available and anyone who runs `blade update` will get the new version. See [Create a snapshot release](#create-a-snapshot-release) right after releasing a stable version.

## Create a snapshot release

1. Create a new branch based for updating to new snapshot release

1. Run `gradlew prepareSnapshot`

1. Commit the changes using the release ticket

1. Create a PR

1. If it passes CI, merge the PR

By merging this PR to master with all the version numbers for components that end in `-SNAPSHOT` this will cause the GitHub workflow to release the binaries for a new snapshot release.
8 changes: 4 additions & 4 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import org.osgi.framework.Version
buildscript {
dependencies {
classpath group: "com.liferay", name: "com.liferay.gradle.plugins.change.log.builder", version: "1.1.1"
classpath group: "com.liferay", name: "com.liferay.gradle.plugins.source.formatter", version: "5.1.75"
classpath group: "com.liferay", name: "com.liferay.gradle.plugins.source.formatter", version: "latest.release"
classpath group: "nu.studer", name: "gradle-credentials-plugin", version: "2.1"
classpath group: "org.osgi", name: "osgi.core", version: "6.0.0"
}
Expand Down Expand Up @@ -180,7 +180,7 @@ repositories {

if (!remoteNexus) {
maven {
url "http://localhost:8081/nexus/content/groups/public/"
url "https://localhost:8081/nexus/content/groups/public/"
}
}
}
Expand Down Expand Up @@ -312,10 +312,10 @@ subprojects {
liferayNexusPassword = "admin123"

if (release) {
repoUrl = "http://localhost:8081/nexus/content/repositories/releases/"
repoUrl = "https://localhost:8081/nexus/content/repositories/releases/"
}
else {
repoUrl = "http://localhost:8081/nexus/content/repositories/snapshots/"
repoUrl = "https://localhost:8081/nexus/content/repositories/snapshots/"
}
}
else {
Expand Down
17 changes: 17 additions & 0 deletions cli/blade-jar-smoke-tests.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ task testBladeInitCommandLegacy(type: JavaExec)
task testBladeInitCommandList(type: JavaExec)
task testBladeInitCommandListAll(type: JavaExec)
task testBladeReturnCodeFailure(type: Exec)
task testBladeSamplesClientExtensionCommand(type: JavaExec)
task testBladeSamplesCommand(type: JavaExec)
task testBladeVersionCommand(type: JavaExec)

Expand Down Expand Up @@ -403,6 +404,22 @@ testBladeReturnCodeFailure {
}
}

testBladeSamplesClientExtensionCommand {
args = [jar.archivePath, "samples", "client-extensions", "-d", clientExtensionDir.path, "liferay-sample-global-css"]
standardOutput = standardStream
errorOutput = errorStream

doLast{
File projectDir = new File(clientExtensionDir, "liferay-sample-global-css")
String error = errorStream.toString().toLowerCase()

errorStream.reset()
standardStream.reset()

assert projectDir.exists()
}
}

testBladeSamplesCommand {
args = [jar.archivePath, "samples", "-v", "7.1"]
standardOutput = standardStream
Expand Down
9 changes: 1 addition & 8 deletions cli/bnd.bnd
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,6 @@ Private-Package:\
\
com.liferay.blade.gradle.tooling,\
\
com.liferay.portal.tools.bundle.support,\
com.liferay.portal.tools.bundle.support.commands,\
com.liferay.portal.tools.bundle.support.constants,\
com.liferay.portal.tools.bundle.support.internal,\
com.liferay.portal.tools.bundle.support.internal.util,\
com.liferay.portal.tools.bundle.support.util,\
\
groovy.json,\
\
org.apache.commons.beanutils,\
Expand Down Expand Up @@ -203,7 +196,7 @@ Private-Package:\
\
org.objectweb.asm.*,\
\
org.osgi.dto,\
org.osgi.dto;-split-package:=merge-first,\
org.osgi.framework;-split-package:=merge-first,\
org.osgi.framework.dto,\
org.osgi.resource;-split-package:=merge-first,\
Expand Down
Loading
Loading