LPS-160184 bnd plugin should not add Imports for Classes #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
ci:test:sf |
|
ci:test:gradle-plugins |
|
ci:test:relevant |
|
ci:test:stable |
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - failure
and removed
ci:test:sf - pending
labels
❌ ci:test:sf - 0 out of 1 jobs passed in 17 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-160184-3 1 Failed Jobs:For more details click here. [java] java.lang.Exception: Found 1 formatting issues:
[java] 1: ./modules/apps/layout/layout-taglib/src/main/resources/META-INF/resources/init.jsp expected:<...p://liferay.com/tld/[frontend" prefix="liferay-frontend" %><%@
[java] taglib uri="http://liferay.com/tld/theme" prefix="liferay-theme" %><%@
[java] taglib uri="http://liferay.com/tld/util" prefix="liferay-util" %>
[java]
[java] <%@ page import="com.liferay.portal.kernel.util.Getter]Util" %>
[java]
[java] <liferay-f...> but was:<...p://liferay.com/tld/[aui" prefix="aui" %><%@
[java] taglib uri="http://liferay.com/tld/frontend" prefix="liferay-frontend" %><%@
[java] taglib uri="http://liferay.com/tld/theme" prefix="liferay-theme" %><%@
[java] taglib uri="http://liferay.com/tld/util" prefix="liferay-util" %>
[java]
[java] <%@ page import="com.liferay.portal.kernel.json.JSONArray" %><%@
[java] page import="com.liferay.portal.kernel.model.LayoutConstants" %><%@
[java] page import="com.liferay.portal.kernel.util.GetterUtil" %><%@
[java] page import="com.liferay.portal.kernel.util.HtmlUtil" %><%@
[java] page import="com.liferay.portal.kernel.util.PortalUtil" %><%@
[java] page import="com.liferay.portal.kernel.util.SessionClicks" %><%@
[java] page import="com.liferay.portal.kernel.util.Validator" %><%@
[java] page import="com.liferay.portal.util.PropsValues" %><%@
[java] page import="com.liferay.taglib.aui.AUI]Util" %>
[java]
[java] <liferay-f...>
[java]
[java] at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:444)
[java] at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:286)
[stopwatch] [run.batch.test.action: 15:36.802 sec]
[echo] The following error occurred while executing this line:
[echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:443: The following error occurred while executing this line:
[echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:596: Java returned: 1
[get] Getting: http://test-1-31/job/test-portal-source-format/4442//consoleText
[get] To: /opt/dev/projects/github/liferay-portal/20230105041405540.txt
[delete] Deleting: /opt/dev/projects/github/liferay-portal/20230105041405540.txt
[delete] Deleting: /opt/dev/projects/github/liferay-portal/null1395478363.properties
|
|
Jenkins Build:test-portal-source-format#4442 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:simonjhy#104 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#16482 |
✔️ ci:test:stable - 29 out of 29 jobs passed in 1 hour 5 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 5ac1719def591d0d5c2232a4a0109d4b8c05e3e0 ci:test:stable - 29 out of 29 jobs PASSED29 Successful Jobs:
For more details click here. |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#7739 Jenkins Report:jenkins-report.html Jenkins Suite:stable Pull Request:simonjhy#104 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#17780 |
liferay-continuous-integration
added
ci:test:gradle-plugins - success
and removed
ci:test:gradle-plugins - pending
labels
✔️ ci:test:gradle-plugins - 2 out of 2 jobs passed in 1 hour 12 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 5ac1719def591d0d5c2232a4a0109d4b8c05e3e0 ci:test:gradle-plugins - 2 out of 2 jobs PASSED2 Successful Jobs:
For more details click here. |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#5559 Jenkins Report:jenkins-report.html Jenkins Suite:gradle-plugins Pull Request:simonjhy#104 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#12382 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#6415 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:simonjhy#104 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#15172 |
|
ci:test:relevant |
|
ci:test:gradle-plugins |
|
ci:test:relevant |
|
ci:test:stable |
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:relevant - pending
ci:test:stable - pending
ci:test:gradle-plugins - pending
ci:test:sf - failure
and removed
ci:test:sf - failure
ci:test:relevant - failure
ci:test:stable - success
ci:test:gradle-plugins - success
ci:test:stable - pending
ci:test:sf - pending
labels
❌ ci:test:sf - 0 out of 1 jobs passed in 17 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-160184-3 1 Failed Jobs:For more details click here. [java] java.lang.Exception: Found 3 formatting issues:
[java] 1: Class/package does not exist: com.liferay.journal.lar: ./modules/apps/journal/journal-service/src/main/resources/META-INF/module-log4j.xml (SourceCheck:XMLLog4jLoggersCheck)
[java] 2: ./modules/dxp/apps/segments/segments-asah-connector/src/main/java/com/liferay/segments/asah/connector/internal/client/AsahFaroBackendClientImpl.java expected:<...ables;
[java] \}
[java]
[java] private [MultivaluedMap<String, Object> _getUriVariables(
[java] int cur, int delta, List<OrderByField> orderByFields,
[java] String fieldNameContext) \{
[java]
[java] return _getUriVariables(
[java] cur, delta, orderByFields, fieldNameContext,
[java] new MultivaluedHashMap<>());
[java] \}
[java]
[java] private MultivaluedMap<String, Object> _getUriVariables(
[java] int cur, int delta, List<OrderByField> orderByFields,
[java] String fieldNameContext, MultivaluedMap<String, Object> uriVariables) \{
[java]
[java] uriVariables.putSingle("page", cur - 1);
[java] uriVariables.putSingle("size", delta);
[java]
[java] if (ListUtil.isEmpty(orderByFields)) \{
[java] return uriVariables;
[java] \}
[java]
[java] List<Object> sort = new ArrayList<>();
[java]
[java] for (OrderByField orderByField : orderByFields) \{
[java] String fieldName = orderByField.getFieldName();
[java]
[java] if (!orderByField.isSystem() && (fieldNameContext != null)) \{
[java] fieldName = StringUtil.replace(
[java] fieldNameContext, CharPool.QUESTION, fieldName);
[java] \}
[java]
[java] sort.add(fieldName + StringPool.COMMA + orderByField.getOrderBy());
[java] \}
[java]
[java] uriVariables.put("sort", sort);
[java]
[java] return uriVariables;
[java] \}
[java]
[java] private String _invoke(Http.Options httpOptions) throws Exception \{
[java] String response = _http.URLtoString(httpOptions);
[java]
[java] Http.Response httpResponse = httpOptions.getResponse();
[java]
[java] if (httpResponse.getResponseCode() != HttpURLConnection.HTTP_OK) \{
[java] if (_log.isDebugEnabled()) \{
[java] _log.debug("Response code " + httpResponse.getResponseCode());
[java] \}
[java]
[java] throw new NestableRuntimeException( |
liferay-continuous-integration
added
ci:test:gradle-plugins - success
and removed
ci:test:gradle-plugins - pending
labels
✔️ ci:test:gradle-plugins - 2 out of 2 jobs passed in 1 hour 5 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: b38777bdf00d43dcb9d978655717a3c5886179e1 ci:test:gradle-plugins - 2 out of 2 jobs PASSED2 Successful Jobs:
For more details click here. |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#2898 Jenkins Report:jenkins-report.html Jenkins Suite:gradle-plugins Pull Request:simonjhy#104 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#6682 |
liferay-continuous-integration
added
ci:test:stable - success
and removed
ci:test:stable - pending
labels
✔️ ci:test:stable - 29 out of 29 jobs passed in 2 hours 37 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: b38777bdf00d43dcb9d978655717a3c5886179e1 ci:test:stable - 29 out of 29 jobs PASSED29 Successful Jobs:
For more details click here. |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#7577 Jenkins Report:jenkins-report.html Jenkins Suite:stable Pull Request:simonjhy#104 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#18116 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#8853 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:simonjhy#104 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#20046 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.