-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds footprint option to cluster likelihoods #140
Draft
mattyowl
wants to merge
78
commits into
master
Choose a base branch
from
dev-clusters-footprints
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DR5_tenToA0Tuned-Q_injection_boris.ipynb
first attempt of trying pytest for both binned and unbinned cluster likelihood
speeding up the unbinned lkl without scatter (no repeated reading in for injection Q) and tidying up (removing obsolete funcs and renaming some params and funcs for clarity). rms_bin_index is not needed anymore for prediction, but still needed for rate densities.
for some reason, vectorisation for Pfun_per didn't speed up the code at all on my side. went back to the older version and read the entire catalogue at once and pass the tile index in computation of y0. starting preparation for inclusion of scatter.
synchronizing intrinsic scatter computation between binned and unbinned lkl (log10(y0) is switched to ln(y0) in unbinned)
switching back to error function for completeness
comoving volume element added for the rate density calculation, an interpolator for the comoving volume element added, source injection method for the unbinned implemented, low redshift cut for the unbinned implemented, application of debias factor checked
minor change with cash statistics, binned intrinsic scatter part
Select a footprint by adding e.g. footprint: 'DES' to the data section of the .yml file. Also changed the way in which paths are given (because the structure of the selFn directory produced by nemo is always the same). So just two paths should be needed - one for the catalog (cat_file) and one for the selFn directory (selfn_path).
mattyowl
changed the title
Dev clusters footprints
Adds footprint option to cluster likelihoods
Jul 18, 2023
Nemo no longer has any Cython parts and is now pure Python, so this should not complicate installation of SOLikeT.
Avoids sharp import
For binned likelihood only, with scatter for now. Using the exponential + pedestal model to add optimization bias to predicted y0 based on sims.
And some commented out code for debugging purposes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds option to specify
footprint
in thedata
section of cluster likelihood Cobaya config .yaml files. This allows one to select a subset of the full ACT/SO survey area (e.g.DES
) - to ensure a region with complete optical follow-up is selected. Some other changes to thedata
section of cluster likelihood .yaml files: now the user only needs to give thecat_file
andselfn_path
parameters - other files needed by the likelihood are found automatically).Merging will also close #70, #69 (and #55 is related).