-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SO Foreground marginalization #158
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
==========================================
- Coverage 74.61% 69.87% -4.74%
==========================================
Files 33 36 +3
Lines 2029 2221 +192
==========================================
+ Hits 1514 1552 +38
- Misses 515 669 +154
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks generally good! I think that I would be happy to merge after you add a test.
Ideally the test would check against both a fixed likelihood value, and also verify that the CMBOnly likelihood is consistent with what one would expect from the MFLike likelihood (i.e. the validation you have done elsewhere). But just against a fixed value would do if that isn't easy.
In the long run I am also not convinced that the foregroundmarginalizer stuff belongs in SOLikeT. It seems like it would be better as its own package, with SOLikeT as a requirement. Happy to do that some time in the future though.
from ..ps import BinnedPSLikelihood | ||
|
||
|
||
class CMBonly(BinnedPSLikelihood): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would CMBOnly
be the correct camel case? :-p
I would have thought the code for doing the marginalization would be better a separate package, and just include the public-facing pre-marginalized likelihood in SOLikeT? (or it could go in mflike) Not sure why you have np.exp(rat) in the acceptance criterion (can't use default Cobaya sampling for some reason?). |
This is a work-in-progress for the foreground marginalization & fg-marginalized likelihood codes for Simons Observatory. The methodology is comparable to the original pliklite code for Planck (gibbs sampling of the CMB bandpowers).
Current steps that are to be done by the end of this PR:
Steps that might be needed but can be done at a later stage:
PR is mainly for tracking progress updates.
Will request a review once the branch is in a state where it can be merged.