-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more flexible CosmoPower network settings. #88
Conversation
Current state is good enough to go into main branch for me, it already allows for an improved experience by end-users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just need to mention that the ell_factors are for CLASS units.
Any updates on this @itrharrison ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to have a more extensive test suite, but I am happy with this for now.
* Allow user-specified number of networks. * Minor mistake in error string formatting. * Added option for internal ell-factor in network. * Bugfix. * Changed which parameters get passed on to network. * Added Clpp support. * Generalized CMB unit factor. * Added parameter requirements for cobaya standard. * Added general ell factor function and type hinting. * Added ell_factor docstring. * Fixed a bug where cobaya would not resume a run due to default argument overwrite. * Using BoltzmannBase.renames instead of old system. * Added Derived parameter network. * Codestyle. * Added init file change. * Docstring changes in prep for #37 * Updated pytest. * Codestyle. * codestyle fixes * fixed data location for tests * fixed test data path * syntax for py37 * added need to install cosmopower --------- Co-authored-by: Ian Harrison <[email protected]>
CosmoPower as it currently stands requires the user to include a TT/TE/EE network of NN/PCAplusNN/NN type. Since this is a pretty strict set of requirements, this commit works on changing that.
Instead of each network being defined only by a network path, there is now a
network_settings
dict within the CosmoPower theory block, which lists each network and what type of network it specifies. This allows one to:Some things that might be worthwhile adding before or after this merge include:
Derived parameter networks (see Boris Bolliet's work).Added in cdf3e80.