Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum elevation check for CMB and Calib blocks #150

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mmccrackan
Copy link
Collaborator

@mmccrackan mmccrackan commented Dec 23, 2024

Added a check for whether CMB and calibration blocks are above the sun avoidance minimum elevation. An assert error will be thrown if any blocks are too low. This is added before gap blocks or moves are calculated, which should all be guaranteed to be above the minimum elevation anyway. Block division or merging shouldn't affect things either.

Intended to address #107.

@mmccrackan
Copy link
Collaborator Author

mmccrackan commented Dec 23, 2024

I didn't notice #108 when I first pushed this, but that was closed and not merged, so I've taken a few pieces from that and incorporated them here. I think the min_el comments in #108 have been addressed due to the addition of parts from the dev branch that allow build_ops to have access to policy parameters.

@kmharrington
Copy link
Member

Looking at this, it bothers me a little that we're using the sun avoidance policy as the place to set the elevation limit. The elevation limits come from settings in the ACU, same as the 'az_limits' in the 'plan_moves' config.

The sun avoidance calculator might also need to know how low the telescope can move in elevation, but the limit is broader than just sun avoidance.

@mmccrackan
Copy link
Collaborator Author

Looking at this, it bothers me a little that we're using the sun avoidance policy as the place to set the elevation limit. The elevation limits come from settings in the ACU, same as the 'az_limits' in the 'plan_moves' config.

The sun avoidance calculator might also need to know how low the telescope can move in elevation, but the limit is broader than just sun avoidance.

Okay, I separated them to match the az_limits dict for now and added an upper limit for completeness/sanity checking. I made it so it will always be a required input unlike az_limits since they might change.

@mmccrackan mmccrackan marked this pull request as ready for review January 27, 2025 15:18
@mmccrackan mmccrackan linked an issue Jan 27, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Elevation limits
2 participants