Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining dev and main #155

Merged
merged 16 commits into from
Jan 27, 2025
Merged

Combining dev and main #155

merged 16 commits into from
Jan 27, 2025

Conversation

mmccrackan
Copy link
Collaborator

@mmccrackan mmccrackan commented Jan 8, 2025

Builds on #101, but decided to make a new branch and PR so as not to mess with the yg/dev branch too much. This branch imports changes that were implemented into BuildOps from the main branch into SatPolicy to work with the new SatPolicy and BuildOpsSimple framework from the yg/dev branch. Some things in PlanMoves also needed changing which breaks support of BuildOps.

These include for now:

  • Splitting the cmb observations (merging again not implemented but might not be required in new framework).
  • Checking to make sure blocks only start pre-block operations when sun-safe.
  • Handling stow az and alt.
  • Move to sun-safe position if home_at_end is False.

@mmccrackan
Copy link
Collaborator Author

I'll mark this as ready for review so we can start testing it on actual schedules and replace the older version. It should have everything from the recent pushes in it, including #147, #148, #151, #154, and #160.

@mmccrackan mmccrackan marked this pull request as ready for review January 15, 2025 20:14
Copy link
Member

@kmharrington kmharrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite thing this branch has wire grid calibrations all the way out so that there's an easy way to call them? As is I didn't test that part.

Otherwise it looks like all these changes still work out to very similar schedules as before and I'm good to merge it (we don't have any SATs actively running wire grid atm so I'm ok for that to remain a to-do item to finish it).

@mmccrackan
Copy link
Collaborator Author

I don't quite thing this branch has wire grid calibrations all the way out so that there's an easy way to call them? As is I didn't test that part.

Otherwise it looks like all these changes still work out to very similar schedules as before and I'm good to merge it (we don't have any SATs actively running wire grid atm so I'm ok for that to remain a to-do item to finish it).

Yeah, I think much of the wiregrid parts in here are related to their scheduling and will end up being removed once they are added to the master schedule and treated similar to CMB obs, so it probably won't be too useful to test them here anyway.

@mmccrackan mmccrackan merged commit fedb3a6 into main Jan 27, 2025
@mmccrackan mmccrackan deleted the 20250108_dev_update branch January 27, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants