Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_op: rewrap az when outside specified limits #97

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guanyilun
Copy link
Collaborator

fix #90

@kmharrington
Copy link
Member

Ok question about this setup. Do the sun-safety checks happen after this un-wrapping? Right now it looks like it's quietly over-riding the az_branch setting for the example below. I'm happy it's found a safe scan but the original az-branch thoughts were for dodging to one side of the sun or the other and I'm seeing "solve sun safe moves" in before the "unwrapping" log messages.

run_config.yaml

platform: satp1

# yaml loads iso format automatically into datetimes
t0: 2024-08-20T20:00:00+00:00
t1: 2024-08-21T20:00:00+00:00
t0_state_file: None

elevation: 60
boresight: 0
az_speed: 0.5
az_accel: 1.0

# optional, only needed if running non-defaults
hwp_dir: True # True: forwards, False: backwards
home_at_end: True # Home: spin down HWP and go to (180,60)
run_relock: False # Relock detectors at the beginning of the schedule
no_cmb: False

cal_targets:
  - source: moon
    # boresight: # if not specified, use scan boresight
    elevation: 50
    focus: 'ws0,ws4,ws1'
    allow_partial: False
    az_branch: 270
  - source: jupiter
    # boresight: # if not specified, use scan boresight
    elevation: 48
    focus: 'ws1'
    allow_partial: True
    az_branch: 270 
2024-09-20 19:28:24,607 [INFO] ================ solve moves ================ 
2024-09-20 19:28:24,607 [INFO] step 1: solve sun-safe moves 
2024-09-20 19:28:24,607 [INFO] block az (439.9964870742548) outside limits, unwrapping... 
2024-09-20 19:28:24,607 [INFO] -> unwrapping az: 439.9964870742548 -> 79.99648707425479 
2024-09-20 19:28:24,607 [INFO] block az (439.9964870742548) outside limits, unwrapping... 
2024-09-20 19:28:24,607 [INFO] -> unwrapping az: 439.9964870742548 -> 79.99648707425479 
2024-09-20 19:28:24,607 [INFO] block az (439.9964870742548) outside limits, unwrapping... 
2024-09-20 19:28:24,607 [INFO] -> unwrapping az: 439.9964870742548 -> 79.99648707425479 
2024-09-20 19:28:25,156 [INFO] step 2: simplify moves 
2024-09-20 19:28:25,157 [INFO] simplify_moves: i_pass=0 
2024-09-20 19:28:25,157 [INFO] simplify_moves: IR converged 
2024-09-20 19:28:25,157 [INFO] ================ lowering (ops) ================ 

@guanyilun
Copy link
Collaborator Author

This rewrapping happens before actually solving for sun-safe moves, so I don't think it will cause new sun-safety problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moon scan runs into satp1 software prelimit for az CCW sector
2 participants