Adds force_pointing kw to match_params
#924
Conversation
This which will only match resonators that have pointing information provided. This also adds the ability to set resonator pointing from the `from_aman` function.
There was a problem hiding this comment.
As discussed I think a more complete matching rule for incorporating strict position info would need to consider the detector type:
- NC: do not match (these don't have design_freq anyway)
- DARK, SLOT: may or may not have position meas.
- UNRT, SQID, BARE: must not have position meas.
- OPTC: must have position meas.
|
Alright, I added different pointing checks that depend on the det-type like you described above, and confirmed that it still works and that I still get good matches. Info on the new match solutions + plots are here: https://simonsobs.atlassian.net/wiki/x/RwC2JQ I also changed the config option from |
sotodlib/coords/det_match.py
Outdated
| def get_det_type_mask(arr: np.ndarray, det_types: List[str]) -> np.ndarray: | ||
| """ | ||
| Returns a boolean mask of all dets that have specific detector types. | ||
| """ | ||
| return np.logical_or.reduce([ | ||
| arr['det_type'] == dt | ||
| for dt in det_types | ||
| ]) |
There was a problem hiding this comment.
I think you are looking for np.isin!
| mat[m, :] = np.inf | ||
| m = np.isnan(dst_arr['xi']) | np.isnan(dst_arr['eta']) | ||
| mat[:, m] = np.inf | ||
| if self.match_pars.enforce_pointing_reqs: |
There was a problem hiding this comment.
So in this block, 'DARK' and 'SLOT' are implicitly untouched. I think you need to at least comment on DARK/SLOT, if not check explicitly that everything you haven't directly modified is listed as DARK or SLOT.
sotodlib/coords/det_match.py
Outdated
| enforce_pointing_reqs (bool): | ||
| If True, will enforce pointing requirements that depend on resonator | ||
| type. |
There was a problem hiding this comment.
Either here, or somewhere else, explain in words what those requirements are (i.e. OPTC must have a position match, DARK/SLOT may have a position match, and everything else must not).
force_pointingmatch param that will make it so only detectors with pointing information are matched.force_src_pointingparam (which would force a match if pointing is provided) since this was always buggy and never had good resultsResSet.from_amanfunction.