Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

G3thwp update template subtraction #931

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

G3thwp update template subtraction #931

wants to merge 28 commits into from

Conversation

ykyohei
Copy link
Contributor

@ykyohei ykyohei commented Aug 21, 2024 •
edited
Loading

This PR will update the hwp_angles metadata

  • Improve template subtraction. Done
  • Improve robustness of hwp_angle solution against noise in encoder data. Done
  • Fix bug of filled_flag. WIP
  • Make new bad revolution flag. Done
  • Add data quality WIP?

Following are moved to separate PR.

  • Improve logging. Done
  • Fix nan problems. Done
    • hwp_angle had nan in the observation that the hwp stopped in the middle of observations.

@17-sugiyama

This comment was marked as resolved.

Sign in to view
@17-sugiyama 17-sugiyama requested review from 17-sugiyama and removed request for 17-sugiyama September 2, 2024 10:29
@ykyohei

This comment was marked as resolved.

Sign in to view
@ykyohei ykyohei mentioned this pull request Oct 8, 2024
Closed
@ykyohei ykyohei changed the title G3thwp update G3thwp update template subtraction Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ykyohei @17-sugiyama