-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gp/fix/act flags #947
base: master
Are you sure you want to change the base?
Gp/fix/act flags #947
Conversation
…rs to make maps with downsampling
I think we need to rethink this -- the additions actually break the abstraction (note the SignalCut inherits from Signal); MLMapmaker caches several Signal objects in So I suspect the right thing to do is have the |
I moved the path information in the |
I think going through the Signal objects is fine. We could also go through the init of the MLMapmaker object and pass it there as a "global" parameter that applies to all sub-signal objects included. |
Included. Also the ACT tod that was causing errors now works. |
This PR makes the glitch path configurable for glitch flags. It assumes that the flags are under a nested path and traverses it based on a separator. This can later be expanded to accept operations over paths.