Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gp/fix/act flags #947

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Gp/fix/act flags #947

wants to merge 11 commits into from

Conversation

iparask
Copy link
Member

@iparask iparask commented Sep 9, 2024

This PR makes the glitch path configurable for glitch flags. It assumes that the flags are under a nested path and traverses it based on a separator. This can later be expanded to accept operations over paths.

@mhasself
Copy link
Member

I think we need to rethink this -- the additions actually break the abstraction (note the SignalCut inherits from Signal); MLMapmaker caches several Signal objects in self.signals, and loops over them.

So I suspect the right thing to do is have the glitch_flags setting enter through the SignalCut constructor, and be saved as an instance variable.

@iparask
Copy link
Member Author

iparask commented Sep 23, 2024

I moved the path information in the init of the signal classes.

@chervias
Copy link
Contributor

I think going through the Signal objects is fine. We could also go through the init of the MLMapmaker object and pass it there as a "global" parameter that applies to all sub-signal objects included.

@iparask
Copy link
Member Author

iparask commented Sep 24, 2024

I think going through the Signal objects is fine. We could also go through the init of the MLMapmaker object and pass it there as a "global" parameter that applies to all sub-signal objects included.

Included. Also the ACT tod that was causing errors now works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants