Fix infinite loop in det-match script #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhasself
approved these changes
Sep 16, 2024
Comment on lines
439
to
440
| run_match(runner, remaining_detsets[0]) | ||
| update_manifests_all(runner) |
There was a problem hiding this comment.
Would it make sense here to keep trying to run a remaining_detset until one actually succeeds?
In the current code, if it gets hung up on a failed one, but can't add it to failed cache, then it will not be able to run anything else in the mean time.
There was a problem hiding this comment.
Sure, that makes sense to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently SATP3 detmatches are being held up because the script loops infinitely if a match fails but is too new to add to the file cache. This addresses that bug, and resolves #956.
This has been tested by rebuilding the satp3 detmatch db in my home dir.