Skip to content

Commit

Permalink
Fix httpx warning about app=self.app, refs #2307
Browse files Browse the repository at this point in the history
  • Loading branch information
simonw committed Mar 15, 2024
1 parent 8b6f155 commit 5af6837
Showing 1 changed file with 24 additions and 8 deletions.
32 changes: 24 additions & 8 deletions datasette/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -1934,36 +1934,52 @@ def _fix(self, path, avoid_path_rewrites=False):
return path

async def get(self, path, **kwargs):
async with httpx.AsyncClient(app=self.app) as client:
async with httpx.AsyncClient(
transport=httpx.ASGITransport(app=self.app)
) as client:
return await client.get(self._fix(path), **kwargs)

async def options(self, path, **kwargs):
async with httpx.AsyncClient(app=self.app) as client:
async with httpx.AsyncClient(
transport=httpx.ASGITransport(app=self.app)
) as client:
return await client.options(self._fix(path), **kwargs)

async def head(self, path, **kwargs):
async with httpx.AsyncClient(app=self.app) as client:
async with httpx.AsyncClient(
transport=httpx.ASGITransport(app=self.app)
) as client:
return await client.head(self._fix(path), **kwargs)

async def post(self, path, **kwargs):
async with httpx.AsyncClient(app=self.app) as client:
async with httpx.AsyncClient(
transport=httpx.ASGITransport(app=self.app)
) as client:
return await client.post(self._fix(path), **kwargs)

async def put(self, path, **kwargs):
async with httpx.AsyncClient(app=self.app) as client:
async with httpx.AsyncClient(
transport=httpx.ASGITransport(app=self.app)
) as client:
return await client.put(self._fix(path), **kwargs)

async def patch(self, path, **kwargs):
async with httpx.AsyncClient(app=self.app) as client:
async with httpx.AsyncClient(
transport=httpx.ASGITransport(app=self.app)
) as client:
return await client.patch(self._fix(path), **kwargs)

async def delete(self, path, **kwargs):
async with httpx.AsyncClient(app=self.app) as client:
async with httpx.AsyncClient(
transport=httpx.ASGITransport(app=self.app)
) as client:
return await client.delete(self._fix(path), **kwargs)

async def request(self, method, path, **kwargs):
avoid_path_rewrites = kwargs.pop("avoid_path_rewrites", None)
async with httpx.AsyncClient(app=self.app) as client:
async with httpx.AsyncClient(
transport=httpx.ASGITransport(app=self.app)
) as client:
return await client.request(
method, self._fix(path, avoid_path_rewrites), **kwargs
)

0 comments on commit 5af6837

Please sign in to comment.