prf: getAboveTablePanelConfigs -> makeAboveTablePanelConfigs for more…

… action oriented verbs
simonw · Apr 20, 2023 · cef6740 · cef6740
1 parent 0536f5d
commit cef6740
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/datasette/static/datasette-manager.js b/datasette/static/datasette-manager.js
@@ -47,7 +47,7 @@ const datasetteManager = {
     datasetteManager.plugins.set(name, pluginMetadata);
 
     // If the plugin partipates in the panel... update the panel.
-    if (pluginMetadata.getAboveTablePanelConfigs) {
+    if (pluginMetadata.makeAboveTablePanelConfigs) {
       datasetteManager.renderAboveTablePanel();
     }
   },
@@ -120,9 +120,9 @@ const datasetteManager = {
     }
 
     datasetteManager.plugins.forEach((plugin, pluginName) => {
-      const { getAboveTablePanelConfigs: getPanelConfigs } = plugin;
+      const { makeAboveTablePanelConfigs } = plugin;
 
-      if (getPanelConfigs) {
+      if (makeAboveTablePanelConfigs) {
         const controls = aboveTablePanel.querySelector('.tab-controls');
         const contents = aboveTablePanel.querySelector('.tab-contents');
 

diff --git a/datasette/static/table-example-plugins.js b/datasette/static/table-example-plugins.js
@@ -33,7 +33,7 @@ const addPlugins = (manager) => {
 
   manager.registerPlugin("panel-plugin-graphs", {
     version: 0.1,
-    getAboveTablePanelConfigs: () => {
+    makeAboveTablePanelConfigs: () => {
       return [
         {
           id: 'first-panel',
@@ -62,7 +62,7 @@ const addPlugins = (manager) => {
 
   manager.registerPlugin("panel-plugin-maps", {
     version: 0.1,
-    getAboveTablePanelConfigs: () => {
+    makeAboveTablePanelConfigs: () => {
       return [
         {
           // ID only has to be unique within a plugin, manager namespaces for you