Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove an unused app var in cli.py #2034

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

wenhoujx
Copy link

@wenhoujx wenhoujx commented Mar 7, 2023

this var app isn't actually used? unless init it does some side-effect outside of the event loop, idon't think it's necessary.

Feel free to ignore this PR if the deleted line actually does something.


📚 Documentation preview 📚: https://datasette--2034.org.readthedocs.build/en/2034/

this var isn't actually used? unless init it does some side-effect outside of the event loop, idon't think it's necessary. 

Feel free to ignore this PR if the deleted line actually does something.
@simonw
Copy link
Owner

simonw commented Mar 9, 2023

Good catch, thanks.

@wenhoujx
Copy link
Author

@simonw any idea why the test coverage check fails?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants