Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated/unused args from setup.py #2222

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

gerrymanoim
Copy link
Contributor

@gerrymanoim gerrymanoim commented Dec 27, 2023

These were added in be768f2 and 47e689a and as best as I can tell no longer used.

Pypa states that these are deprecated and pytest-runner itself recommends removing them.


📚 Documentation preview 📚: https://datasette--2222.org.readthedocs.build/en/2222/

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45b88f2) 92.62% compared to head (b1497ce) 92.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2222   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files          40       40           
  Lines        6075     6075           
=======================================
  Hits         5627     5627           
  Misses        448      448           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonw
Copy link
Owner

simonw commented Jan 31, 2024

Thanks!

@simonw simonw merged commit 04e8835 into simonw:main Jan 31, 2024
12 checks passed
@gerrymanoim gerrymanoim deleted the remove-setup-kwargs branch January 31, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants