Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set link to download db to nofollow #2236

Merged
merged 1 commit into from
Jan 31, 2024
Merged

set link to download db to nofollow #2236

merged 1 commit into from
Jan 31, 2024

Conversation

fgregg
Copy link
Contributor

@fgregg fgregg commented Jan 16, 2024

This directs well-behaved web crawlers to not attempt to download the whole sqlite db, which is something you probably don't want a web crawler to do.


📚 Documentation preview 📚: https://datasette--2236.org.readthedocs.build/en/2236/

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a5adb5) 92.33% compared to head (d780901) 92.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2236      +/-   ##
==========================================
+ Coverage   92.33%   92.64%   +0.30%     
==========================================
  Files          41       40       -1     
  Lines        6134     6090      -44     
==========================================
- Hits         5664     5642      -22     
+ Misses        470      448      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonw
Copy link
Owner

simonw commented Jan 31, 2024

Thanks, this is a good idea.

@simonw simonw merged commit b823069 into simonw:main Jan 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants