don't hide virtual table, hide shadow tables. #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's mark the test that's going to fail in the older SQLite version as |
|
@simonw ready for review! It wasnt' as easy as skipping the test for SQLite 3.37 - since other tests break because of this change (ie table lists that sort by name + hidden status), I couldnt skip all those other non-related tests. So I added some logic that manually adds in FTS3 + FTS4 + FTS5 shadow tables by hard-coded their suffixes. The SQL is a bit nasty, happy to edit that if needed |
|
This looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2296
This will likely fail the SQLite 3.25 test
📚 Documentation preview 📚: https://datasette--2391.org.readthedocs.build/en/2391/