Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 326: validate run summary channels #327

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Patch 326: validate run summary channels #327

wants to merge 17 commits into from

Conversation

kujaku11
Copy link
Collaborator

@kujaku11 kujaku11 commented May 29, 2024

This PR addresses Issue #326 and adds a validation to the RunSummary to check that the input and output channels are consistent between runs. If the channels are not a logger warning is produced. If the use wants they can drop those runs that are inconsistent. Updated tests.

  • Comment out drop_nans in transfer_function_helpers | process_transfer_functions as the nans are taken care of later. This allows for accounting of different channels.

  • Added test in xarray_helpers | handle_nan if the merge does not work with join='exact' then try 'join='outer'

  • Updated decimation method to use scipy.signal xarray accessors built by mth5.timeseries.scipy_filters

  • Tests pass

@kujaku11 kujaku11 requested a review from kkappler May 29, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant