Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nosetest and convert tests to pytest #47

Merged
merged 9 commits into from
Sep 26, 2024

Conversation

mplough-kobold
Copy link
Contributor

Previously the Makefile ran tests using nosetests but CI ran tests using pytest. Nose is very old; the last release on PyPI is 1.3.7 from June 2015.

As pytest provides excellent test tooling, this PR transitions tests, documentation, and support tooling to use only pytest. Tests written in unittest.TestCase style have transitioned to use pytest's xunit support.

As tests/test_Scipy.py did include any class-level setup, I transitioned it to parametrized tests as that implementation is much terser.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.71%. Comparing base (be9af7f) to head (089e975).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
pymatsolver/solvers.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   89.36%   91.71%   +2.34%     
==========================================
  Files           5        7       +2     
  Lines         301      374      +73     
==========================================
+ Hits          269      343      +74     
+ Misses         32       31       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcapriot
Copy link
Member

Hey @mplough-kobold i kinda hijacked your PR here! Thanks for getting this going.

@jcapriot jcapriot merged commit cf3f2e0 into simpeg:main Sep 26, 2024
23 of 24 checks passed
@mplough-kobold mplough-kobold deleted the matt-refactor-tests-as-pytest branch September 27, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants