Refine activation code generation. #1225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, activation code genaration invoked a redudant `str()` conversion (`secrets.cohice(string.digits)` already returns a string). Also, secrets.choice was called six times, which is slower than just one call. I hope this refinement make the code more readable and faster.
weakish
requested review from
acasajus,
cquintana92 and
nguyenkims
as code owners
|
Hey, thanks for contributing! May I suggest a small improvement. At the top define ACTIVATION_CODE_NUM_DIGITS=6and then we can do str(secrets.randbelow(10**ACTIVATION_CODE_NUM_DIGITS)).zfill(ACTIVATION_CODE_NUM_DIGITS)👍 |
|
I applied suggestion in e2b147f (I defined the const in config.py instead of the top of auth.py since it seems most constants are defined there.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, activation code genaration invoked a redudant
str()conversion(
secrets.cohice(string.digits)already returns a string).Also, secrets.choice was called six times, which is slower than just one call.
I hope this refinement make the code more readable and faster.