[AS8-6579] Initial checkin #1
Conversation
cjonesy
requested review from
a team,
ruffin,
jason-h-35 and
joshuawscott
and removed request for
a team
|
FYI - The name of this repo is likely to change to be something that aligns with most of the other community modules. |
|
I realized I had been churning on this module for a while now and figured it would be better to just get it out the door with the existing Slack message formatting (even though they are very lacking). I am hoping that this issue gets handled soon and we can have better info in the messages. However, even if that issue is not resolved, I can build an app that does what we want and override the image with |
main.tf
Outdated
| provider = google-beta | ||
|
|
||
| #FIXME: Is there no way to tell a cloud run service to restart when it's config changes? | ||
| name = "${local.base_name}-${lower(regex("[0-9A-Za-z]+", google_storage_bucket_object.cloud_build_notifier_config.crc32c))}" # HACK To make the cloud run job change when the config changes |
There was a problem hiding this comment.
This feels really gross to me, but I can't find a better way to handle this.
When we make a change to the configuration in a Cloud Run service it doesn't notice and just continues to run with the old configuration.
I read through all the options in the google_cloud_run_service docs, but could not find anything to trigger it to deploy a new revision on config change.
The only way I could come up with is appending the configs crc32 to the end of the service's name... which triggers terraform to destroy and recreate the service.
If anyone has ideas on how to get around this I'd love to hear them!
There was a problem hiding this comment.
hashicorp/terraform#11418
It seems like this approach is the best way (assuming it actually redeploys when the name changes?)
There was a problem hiding this comment.
Yep, I verified that it does redeploy when the config changes.
| # ------------------------------------------------------------------------------ | ||
|
|
||
| # Create cloud build notifier service account | ||
| resource "google_service_account" "notifier" { |
There was a problem hiding this comment.
I think it would be good to output this
There was a problem hiding this comment.
never mind on this, I was confused on what it was used for.
@jason-h-35 - Yep! This module felt generic enough that we could open-source it and push it to terraform registry. |
This module is mostly based almost exactly on the instructions found in GCP's Configuring Slack notifications.
Since there was a significant amount of Terraform code this felt like it should be a standalone Terraform module that can be pulled in to any other module when you want to enable Slack notifications. I also believe we could open source this and push it up to the Terraform Module Registry, so separating it into another repo makes that easier.