fscusat/mirror/archlinux: init #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So what should be the path and what changes should I make? |
|
the arch mirror should be rsynced to /var/lib/arch...* |
|
I updated the paths as requested. If any changes are required, please feel free to ping me. |
sinanmohd
reviewed
Jun 13, 2024
| cmd = pkgs.writeScript "rsync_cmd-${src}" '' | ||
| rsync -rlptH --safe-links --delete-delay --delay-updates \ | ||
| --timeout=600 --contimeout=60 --no-motd \ | ||
| ${if pkgs.stty then "-h -v --progress" else "--quiet"} \ |
There was a problem hiding this comment.
this doesn't make sense semantically, what are you trying to do here
| ${src} ${dest} ${lib.concatMapStrings (s: " '${s}'") extraArgs} | ||
| ''; | ||
| in | ||
| pkgs.stdenv.mkDerivation { |
There was a problem hiding this comment.
This looks like a job for writeShellApplication
|
|
||
| ${rsync} | ||
| ''; | ||
| } |
There was a problem hiding this comment.
there are too much semantic hallucination in this pr :P, i can't review it in this state.
if you're new to nixos please go through nixos and nixpkgs manual and then you can update this pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new Pull Request as I have some doubts regarding the paths and this is a better version which uses the shell script provided by arch linux
A link to the script