feat: add accessibilityPermission option
#177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it's actually not needed, I prefer to just remove it. |
|
Submitted the PR #178 for your review @sindresorhus. Thanks. |
sindresorhus
requested changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
There has been issues with macOS users regarding accessibility permission. The accessibility permission is needed in order to get the complete window title. Apparently, the
screenRecordingPermissionalready handles this concern so there is no need for the accessibility permission. To fix this we could just update theifcondition but just in case, this PR just adds a new optionaccessibilityPermission.accessibilityPermission: false- disables the accessibility permission prompt.Changes
accessibilityPermissionoption.Related
screenRecordingPermissionoption #96