Add intermediate bookmarking implementation #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add associated JIRA ticket with this PR |
shantanu73
reviewed
May 15, 2024
|
|
||
| if next(iter(self.replication_keys or []), None): | ||
| return state.get('bookmarks', {}).get(stream, default), 0 | ||
| else: |
There was a problem hiding this comment.
won't need this else statement
shantanu73
reviewed
May 15, 2024
tap_activecampaign/streams.py
Outdated
| self.stream_name, bookmark_field, last_datetime)) | ||
| now_datetime = utils.now() | ||
| last_dttm = strptime_to_utc(last_datetime) | ||
| LOGGER.info('stream: {}, bookmark_field: {}, last_datetime: {}, offset: {}'.format( |
There was a problem hiding this comment.
Use f-strings instead of format.
|
Addressed the review comments. |
|
Verified interrupted sync and intermediate bookmarking at my end. Apart from my previous comments everything looks fine. |
shantanu73
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Support ticket TDL-25734:
Tap was writing stream bookmark after complete extraction of all stream records. Because of this issue, in some cases we observed that long running historical syncs, after interruption were restarting from the start data and re-extracting duplicate records.
To fix this issue,
offset_bookmark_limit=1000records.offset_bookmark_limit=1000recordsThis will allow interrupted extractions resume from the last bookmark value and reduce duplicate record extraction.
Manual QA steps
offset_bookmark_limitvaluesRisks
Rollback steps