merge fix from PR 94 (Crest-master) to master (#106)

* merge fix from PR 94 (Crest-master) to master * update expected results based on new api responses Co-authored-by: btowles <[email protected]>
singer-io · Jan 26, 2023 · ff684a8 · ff684a8
1 parent 818dfdd
commit ff684a8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/tests/test_all_fields.py b/tests/test_all_fields.py
@@ -28,7 +28,8 @@ class AllFieldsTest(BaseTapTest):
         "issue_transitions": ["fields", "expand"],
         # iconUrl: not found in the doc
         "resolutions": ["iconUrl"],
-        "changelogs": ["historyMetadata"]
+        # historyMetadata started showing up 01/24/2023 so commenting this out for now
+        # "changelogs": ["historyMetadata"]
     }
 
     @staticmethod

diff --git a/tests/test_start_date.py b/tests/test_start_date.py
@@ -10,8 +10,6 @@
 
 from base import BaseTapTest
 
-# BUG_TDL-19582 [tap-jira] tap does not replicate incremental records inclusive of start date
-
 
 class StartDateTest(BaseTapTest):
     """
@@ -73,10 +71,9 @@ def test_run(self):
             replication_key = list(expected_replication_keys_by_stream[stream])[0]
             bookmarked_values.append(state['bookmarks'][stream][replication_key])
 
-        # grab the most recent bookmark from state
-        greatest_bookmark_value = sorted(bookmarked_values)[-1].split("T")[0]
-        start_date = self.timedelta_formatted(greatest_bookmark_value, days=-1, str_format="%Y-%m-%d") # BUG_TDL-19582
-        # start_date = self.timedelta_formatted(greatest_bookmark_value, days=0, str_format="%Y-%m-%d")  # BUG_TDL-19582
+        # grab the minimum bookmark from state to ensure we fetch data from all sync2 streams
+        minium_bookmark_value = sorted(bookmarked_values)[0].split("T")[0]
+        start_date = self.timedelta_formatted(minium_bookmark_value, days=0, str_format="%Y-%m-%d")
         self.start_date = start_date + "T00:00:00Z"
 
         # create a new connection with the new  more recent start_date