add dataConnections metadata, fix updaterId on prospects #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MarkEstey, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
You did it @MarkEstey! Thank you for signing the Singer Contribution License Agreement. |
|
Any update on this? I'll retract my PR i just want the integration to be working again. as long as one of the two works can we please get one reviewed and merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The main change is that I added the "dataConnections" metadata for objects that support it, as this is extremely useful to map objects to other 3rd party platforms that Outreach is integrated with such as Salesforce.
Additionally I included a fix for issue #20 however this fix is different than the pull request already outstanding. The current pull request to fix this issue simply allows the relationship value to override the new attributes, however I instead remove the relationship for "updater" from the prospect schema and add the new attributes "updaterId" and "updaterType" instead. The relationship appears to only return an ID value when the updater is a user and null when it is not a user, however the new attributes appear to give the ID of any object that update the object including but not limited to users. Any downstream logic such as joins using "updaterId" that assume it is always contains a user ID would now need to check the "updaterType" attribute to see if it's a user or not.
Manual QA steps
Risks
Rollback steps