Fix safari clipboard bug #1722
Merged
Fix safari clipboard bug #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sures block that and currently cause safari to display a paste menu
|
Thank you for your contributions. |
10 tasks
EchoEllet
reviewed
Sep 16, 2024
Comment on lines
+86
to
+88
| // Web - esp Safari Mac/iOS has security measures in place that restrict | ||
| // cliboard status checks w/o direct user interaction. So skip this | ||
| // for web |
There was a problem hiding this comment.
If this issue is specific to Safari (Mac/iOS), shouldn't we only introduce this change for safari instead of all browsers?
32 tasks
|
@mtallenca |
|
Only thinking I had was operating systems and browsers moving more and more
into the direction of privacy and any data sharing(i.e.
clipboard) requiring user interaction. I'm still seeing messages in Chrome
console indicating "Third party cookies will be blocked in future Chrome
version as part of privacy sandbox". I don't think it's a stretch that
additional constraints will be applied to clipboard viewing as well. It may
work now in Chrome, but it would not surprise me if that stops working in
the near future.
…On Thu, Sep 19, 2024 at 8:41 AM Ellet ***@***.***> wrote:
@mtallenca <https://github.com/mtallenca>
Can explain why this change was made for all browsers instead of Safari
only?
—
Reply to this email directly, view it on GitHub
<#1722 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXMGLLI47ZXSA3T5S7M3TDZXLWDJAVCNFSM6AAAAABC3K5IWGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRRGM3TIOBWGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thank you for the explanation, I was trying to fix #2220, and I couldn't find where the paste logic is performed for the web. It seems to be separated from non-web platforms. So, I initially thought this was related but didn't seem to be the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Safari 17.2.1 on Desktop and iOS 17 Safari - performing Clipboard status checks causes a "Paste" menu to be displayed and stops user input. The status checks were initialized by ClipboardStatusNotifier when a default value of "unknown" was used in it's constructor as well as each time the editor content changed. This PR gives the web a default value of ClipboardStatus.pasteable and doesn't force update calls when content change on web.
Related Issues
Fix Editor for web app keeps showing "paste" dialog everytime in a read only content page from IOS web browser #1567
Suggestions
Cut/Copy/Paste with keyboard shortcuts work on web, but right click menu items cut/copy/paste do not work correctly. This PR does not address this existing issue.
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
[x] No, this is not a breaking change.