Make some Experiment/Query classes abstract #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-williams
force-pushed
the
rw/abcs
branch
2 times, most recently
from
85a895d
to
e605b6f
Compare
ryan-williams
changed the title
{experiment,query}.py classes abstract
ryan-williams
force-pushed
the
rw/abcs
branch
2 times, most recently
from
79cb3c2
to
884e8a4
Compare
ryan-williams
force-pushed
the
rw/abcs
branch
from
884e8a4
to
8d59b05
Compare
ryan-williams
force-pushed
the
rw/abcs
branch
from
8d59b05
to
2b183cb
Compare
|
I pushed one more commit, explicitly tagging @jp-dark had suggested using |
ryan-williams
force-pushed
the
rw/abcs
branch
from
8f9e174
to
8d76a8a
Compare
@ryan-williams I think the suggestion has merit but I'd prefer to take it as follow-on work and not let it block this current PR. |
ryan-williams
force-pushed
the
rw/abcs
branch
from
8d76a8a
to
55788e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move several classes/files to TileDB-SOMA (single-cell-data/TileDB-SOMA#3307), leave abstract interfaces here.