Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small errata #17

Merged
merged 4 commits into from
Oct 16, 2024
Merged

small errata #17

merged 4 commits into from
Oct 16, 2024

Conversation

bkmartinjr
Copy link
Member

A number of small changes to readme, changelog and an update of pre-commit versions.

@bkmartinjr bkmartinjr changed the title small eratta small errata Oct 15, 2024
Copy link
Member

@ryan-williams ryan-williams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple suggestions, lgtm otherwise

README.md Outdated

> pip install tiledbsoma-ml
> pip install git+<https://github.com/single-cell-data/TileDB-SOMA-ML>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> pip install git+<https://github.com/single-cell-data/TileDB-SOMA-ML>
```bash
pip install git+https://github.com/single-cell-data/TileDB-SOMA-ML
```

Stray angle brackets in there, also a triple-backtick code "fence" makes more sense than a > "quote" block, I think?

README.md Outdated

Developers may install editable, from source, in the usual manner:
Developers may install editable, from source, in the usual manner -- clone the repo and execute:

> pip install -e .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> pip install -e .
```bash
pip install -e .
```

@ryan-williams ryan-williams merged commit d972a84 into main Oct 16, 2024
24 checks passed
@ryan-williams ryan-williams deleted the bkmartinjr/readme-refinement branch October 16, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants