-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with single-spa.js.org @ 1dd80eae #191
Open
single-spa-bot
wants to merge
104
commits into
master
Choose a base branch
from
sync-1dd80eae
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.18.0 to 1.18.1. - [Release notes](https://github.com/http-party/node-http-proxy/releases) - [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md) - [Commits](http-party/node-http-proxy@1.18.0...1.18.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Adding APG eCommerce Solutions Logo Adding Australia Post Global (APG) eCommerce Solutions Logo * Adding APG eCommerce Solutions to users Adding Australia Post Global (APG) eCommerce Solutions to users
Minor change where the example code for pathToActiveWhen had the wrong path. One char added.
* Layout Engine: json dom nodes and error uis * Self review * Self review
fixed webconfig import of `webpack-config-single-spa-react`
Update on monorepos. Possible with modern CI but not (yet) recommended.
updating docs per single-spa/create-single-spa#185 also made the list not in any specific order so we can add/edit/move things around without issues in the future.
* Update separating-applications.md Monorepos are MORE powerful than npm packages. It DOES indeed allow for independent builds and separate deployments, if you configure the CI accordingly. https://medium.com/labs42/monorepo-with-circleci-conditional-workflows-69e65d3f1bd0 https://medium.com/compass-true-north/speeding-up-circleci-checkouts-in-a-monorepo-277af0469fff sample monorepo project for Circle CI: https://github.com/labs42io/circleci-monorepo Youtube tutorial on Circle CI with monorepos: https://www.youtube.com/watch?v=nKA1Tg02CuY * Update website/versioned_docs/version-5.x/separating-applications.md * Update website/versioned_docs/version-5.x/separating-applications.md Co-authored-by: Joel Denning <[email protected]>
Add docs for new `handleInstance` api.
wrapClassName docs
* Add note about webpack 4 vs 5 for parcel import * Update ecosystem-react.md
* Beginnings of server-side rendering documentation. * Adding documentation for server-side rendering. * Examples. * Update website/versioned_docs/version-5.x/server-side-rendering-overview.md Co-authored-by: Carlos <[email protected]> * Update website/versioned_docs/version-5.x/server-side-rendering-overview.md Co-authored-by: Carlos <[email protected]> * Finish documentation for server side rendering. * Angular 9 Co-authored-by: Carlos <[email protected]>
* Integrate with FeaturePeek * Ignore master branch * Only ping featurepeek on non-master branches
This reverts commit adca508.
* Adding documentation for canceling navigation * Update website/versioned_docs/version-5.x/api.md Co-authored-by: Carlos <[email protected]> Co-authored-by: Carlos <[email protected]>
* Adding documentation for single-spa-web-server-utils. * Self review * Update website/versioned_docs/version-5.x/create-single-spa.md Co-authored-by: Carlos <[email protected]> Co-authored-by: Carlos <[email protected]>
* Adding documentation for unregisterApplication. * More docs * Carlos' feedback
format error fix
* Self review * Document exact routes in single-spa-layout
* Update to latest docusaurus alpha version * Rename links to items * Add empty dummy file per error * Fix syntax highlighting css * Fix url for static image * Fix broken link URLs * Convert MD quotes to calllouts * Move filename into MD title * Format with Prettier * Update callout types * Remove extra heading * Fix warnings from bad links; format * Additional link fixes per warnings * Rename custom redirects plugin to silence warning * Update template to match current @docusaurus/client-redirects plugin
* Fix links that point to localhost * Add missing word * Fix typo * Remove extra title
Broken URL
* Update Slack link * Use anumeric sequence for numbered list * Additional Slack links missed
* Document webpack customizations * Update create-single-spa.md * Update create-single-spa.md
* Add Vue public path instructions * Update ecosystem-vue.md
* Documenting AngularJS parcels * Self review
* Snowpack documentation * Self review * Sidebar link * Carlos' feedback * Comment
Co-authored-by: Sergej Popov <[email protected]>
previous statement could be mis-construed, the edit attempts to make it clear that there's only one type of in-browser module being talked about.
* Add Vue public path instructions * Remove project status warning in angular docs * Fix bad merge * Self review
As a person new to Microfrontend, it was awkward for me to have to shift mid-article from using the term Microfrontend to the acronym MFE. My personal opinion is that the acronym should be either introduced early in the article with an explanation (could be as simple as putting the acronym next to the term `Microfrontend (MFE)`) or not used in this article.
…ge (#409) * Update recommended-setup.md Add link to inter-app communication page * Use relative URL Co-authored-by: Carlos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
website/versioned_docs/version-5.x/single-spa-playground.md
website/versioned_docs/version-5.x/separating-applications.md
website/versioned_docs/version-5.x/recommended-setup.md
website/versioned_docs/version-5.x/parcels-overview.md
website/versioned_docs/version-5.x/module-types.md
website/versioned_docs/version-5.x/migrating-existing-spas.md
website/versioned_docs/version-5.x/getting-started-overview.md
website/versioned_docs/version-5.x/examples.md
website/versioned_docs/version-5.x/ecosystem-vue.md
website/versioned_docs/version-5.x/ecosystem-react.md
website/versioned_docs/version-5.x/ecosystem-preact.md
website/versioned_docs/version-5.x/ecosystem-html-web-components.md
website/versioned_docs/version-5.x/devtools.md
website/versioned_docs/version-5.x/create-single-spa.md
website/versioned_docs/version-5.x/building-applications.md
website/versioned_docs/version-5.x/api.md
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from master and cause them to show up as conflicts the next time we merge.