Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed added space changing color with palette #468

Conversation

sakshii00
Copy link
Contributor

@sakshii00 sakshii00 commented Jul 11, 2024

Issue Title: Added space changing color with palette at bottom

closes #425

Preview

Updated the code such that the problem of background color with added/subtracted space doesn't occur.

2024-07-11.16-38-04.mp4
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Updated the code such that the problem of background color with added/subtracted space doesn't occur
Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
draw-it-out ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 11:14am
draw-it-out-zbd1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 11:14am

@sakshii00
Copy link
Contributor Author

@singodiyashubham87 Please review this. Thanks

Copy link
Owner

@singodiyashubham87 singodiyashubham87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@singodiyashubham87 singodiyashubham87 merged commit 52e919f into singodiyashubham87:main Jul 13, 2024
7 checks passed
@singodiyashubham87
Copy link
Owner

@sakshii00 Well Done, Keep it up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants