Feature coredata #19
Open
Feature coredata #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sinnerschrader-mobile/ios to be code reviewed |
added 2 commits
January 8, 2015 11:02
|
Fixes #15 |
|
|
||
| + (NSEntityDescription*)entityInManagedObjectContext:(NSManagedObjectContext*)moc_ | ||
| { | ||
| #warning use mogenerator |
There was a problem hiding this comment.
This is a bit ugly. We should make sure this works with projects that don't use MOGenerator, or that have a different MOGenerator template file.
There was a problem hiding this comment.
Agreed, it seems to be more a dependency, we could remove the method and move the declaration to a protocol. Then use custom mogenerator template to declare the method
…ategory This will make it easier to later move those methods to the MOGenerator template. This commit also groups methods by public/private. The public methods also got shorter names.
Because properties are attributes or relationships, but this method only uses attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15