Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the restriction on Factorised masks to be positive using absolute value (as in ecker 2018) #232

Merged
merged 8 commits into from
Mar 8, 2024

Conversation

pollytur
Copy link
Collaborator

@pollytur pollytur commented Mar 8, 2024

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 7.52%. Comparing base (49a7310) to head (15baed4).

Files Patch % Lines
neuralpredictors/layers/readouts/factorized.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #232      +/-   ##
========================================
- Coverage   7.53%   7.52%   -0.01%     
========================================
  Files         58      58              
  Lines       5959    5965       +6     
  Branches    1011    1013       +2     
========================================
  Hits         449     449              
- Misses      5473    5479       +6     
  Partials      37      37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

neuralpredictors/layers/readouts/factorized.py Outdated Show resolved Hide resolved
neuralpredictors/layers/readouts/factorized.py Outdated Show resolved Hide resolved
neuralpredictors/layers/readouts/factorized.py Outdated Show resolved Hide resolved
neuralpredictors/layers/readouts/factorized.py Outdated Show resolved Hide resolved
neuralpredictors/layers/readouts/factorized.py Outdated Show resolved Hide resolved
@pollytur pollytur requested a review from MaxFBurg March 8, 2024 13:13
@MaxFBurg MaxFBurg merged commit 4ceba76 into sinzlab:main Mar 8, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants