Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tox config and address warnings #85

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix tox config and address warnings #85

wants to merge 2 commits into from

Conversation

A-dead-pixel
Copy link

The python versions in tox.ini are the same as in the pytest workflow.

The warnings that show up when running tox are:

filetracker/servers/run.py:83
  /src/ups-ft/filetracker/servers/run.py:83: DeprecationWarning: invalid escape sequence \|
    return re.sub('\n[ \t]*\|', '\n', text)

filetracker/tests/interaction_test.py::InteractionTest::test_delete_nonexistent_should_404
  /src/ups-ft/filetracker/tests/interaction_test.py:179: DeprecationWarning: Please use assertRaisesRegex instead.
    with self.assertRaisesRegexp(FiletrackerError, "404"):
...

@A-dead-pixel
Update and fix tox config, update .gitignore
d1c17cf
@A-dead-pixel
Address warnings
50bb130 
- use assertRaisesRegex instead of assertRaisesRegexp
- use a raw string for a regex pattern to handle escape sequences
  properly
@Wolf480pl Wolf480pl requested a review from twalen July 19, 2023 18:11
Wolf480pl
Wolf480pl approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@Wolf480pl Wolf480pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk why github wants me to approve it since @twalen is also a codeowner. I didn't look too closely but looks ok on the surface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twalen twalen twalen approved these changes

@Wolf480pl Wolf480pl Wolf480pl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@A-dead-pixel @Wolf480pl @twalen