Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livedata: fix cache_unless_admin_or_observer #387

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

metenn
Copy link
Contributor

@metenn metenn commented May 28, 2024

result.content is of type "bytes", so wrapping it in str() would create a string that's wrapped in b'...', in turn causing JSON.parse() on the client-side scripts for oioioi.liveranking to fail.

result.content is of type "bytes", so wrapping it in str() will create a
 string that's wrapped in b''.
@metenn metenn requested a review from twalen as a code owner May 28, 2024 21:23
@sio2project sio2project deleted a comment from sentry-io bot May 28, 2024
Copy link
Contributor

@twalen twalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a regression test?

@metenn metenn requested a review from twalen June 12, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants