Support installing with pip, and run tests with GitHub Actions #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids exceptions inside tflite_reader.py being swallowed
Requires that one runs with module load option, for example:
python -m tools.tflite2tmdl
OR
python -m tinymaix.tflite2tmdl
So it can be used by Github Actions (or developers locally)
auto_test for mbnet int8 was failing due to this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Zepan. Users of emlearn-micropython (which uses TinyMaix for CNN) reported some problems. There was an exception due to keras.np_utils no longer existing, which was swallowed in the
import tflite_reader. The exception has been fixed, and as well making sure that future exception get an traceback out for easier debugging.The other issue is that they found it annoying to install TinyMaix tools, having to use a git repo/submodule manually etc. This adds support for installing as a Python package (with pip etc).
This also adds basic automated test coverage running in GitHub Actions. As well as some minor improvements in error reporting from the tests, and one fix of a failing testcase. Hopefully makes it easier to verify future contributions :)
Let me know if you want me to split this up into multiple MRs.