Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recording-daemon : notify-purge param removes a file if notify success #1675

Closed

Conversation

sewan-aprodhomme
Copy link

Hi,

We wanted rtpengine to remove records when a notify was successful. We implemented it.
When a POST request success, we remove the output file if notify-purge option is enabled.

Copy link
Member

@rfuchs rfuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this option only makes sense if notify-record is also set? Perhaps add a safeguard to protect against wrong usage, and/or mention it in the docs?

recording-daemon/main.c Outdated Show resolved Hide resolved
recording-daemon/notify.c Outdated Show resolved Hide resolved
@sewan-aprodhomme
Copy link
Author

I suppose this option only makes sense if notify-record is also set? Perhaps add a safeguard to protect against wrong usage, and/or mention it in the docs?

I changed the documentation and the if (notify_record && notify_purge) { accordingly.
I hope it's better now. Tell me if you see something that's still bad !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants