Reject OSRTP answer when not offered #1854
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue has been discussed in the mailing list:
https://groups.google.com/g/rtpengine/c/pFh2T2Nucnw
You have a call where OSRTP is offered from caller, but rejected/ignored by rtpengine.
Later a reINVITE from callee is sent without without crypto attributes towards caller.
Caller then responds with crypto attributes and those are accepted by rtpengine.
Now RTP will stop since it can not decrypt det non-encrypted traffic from caller and/or crypto attributes are not fully set, so it will fail sending encrypted traffic back.
Behaviour is observed for Aastra/Mitel phones and Baresip with "mediaenc=srtp".