Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a nan check to the learner and fixed the ls failure branch #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added a nan check to the learner and fixed the ls failure branch #3

wants to merge 1 commit into from

Conversation

kunalmenda
Copy link
Contributor

learner hadn't imported logger, and so if the line search failed then the script would fail at logger.warn('Line search exceeding 100 iters...breaking.').

Changes:

  • Imported logger in ceem/learner.py.
  • Added an assert False if the line search fails.

@kunalmenda kunalmenda requested a review from rejuvyesh March 30, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rejuvyesh rejuvyesh Awaiting requested review from rejuvyesh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kunalmenda