Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version requirements for julia dependencies #5

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cherrywoods
Copy link

I just added the versions of the dependencies that worked for me to the README file, as mentioned in issue #4.

It would be nice to also add such version notices for the other components as well or even create a docker container that has all the right versions installed, I will see what I stumble across while working with this...

@mykelk
Copy link
Member

mykelk commented Feb 17, 2021

Awesome! Does this look good to you @kjulian3 ?

@cherrywoods
Copy link
Author

I added a Dockerfile that sets up Julia 1.1 and the required packages in a container now. The GenerateTables code is working, I didn't test the PolizyViz code.

@mykelk mykelk requested a review from kjulian3 March 26, 2021 19:43
@zsunberg
Copy link
Member

zsunberg commented Mar 28, 2021 via email

@cherrywoods
Copy link
Author

I think a Manifest.toml file would make sense. I have never really used Julia, so I didn't knew anything about it's package manager, but after what I read on it, a Manifest.toml file seems sensible. I will generate one, after I got to test the PolicyViz code as well.

The docker container is I think still a good thing to have, because I also had some issues running this project with the latest Julia version, if I remember correctly and the best solution I found for using Julia 1.1 was using a container.

@cherrywoods
Copy link
Author

I didn't look into Manifest.toml yet, but I changed the Dockerfile to allow running the PolicyViz notebook inside the container.
I also added a short paragraph at the end of the README file with instructions on running the notebook in the container. In the README I also added Revise to the dependency list, since it is imported in the notebook, but it might not be otherwise necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants